test: Refactors mongodb_advanced_cluster tests (#2361)

* refactor common logic in checks * fix copyChecks * checkTenant * use ComposeAggregateTestCheckFunc * checkSingleProvider * checkAggr * leftovers * fix checkSingleProvider * checkTags * checkMultiCloud * checkMultiCloudSharded and checkSingleProviderPaused * checkAdvanced * checkAdvancedDefaultWrite * checkMultiZoneWithShards * regionConfigs in checkMultiCloud * fix tests * fix TestAccClusterAdvancedCluster_multicloudSharded
mongodb · Jun 25, 2024 · 8f88729 · 8f88729
1 parent 1f1890a
commit 8f88729
Show file tree

Hide file tree

Showing 3 changed files with 201 additions and 288 deletions.
diff --git a/internal/service/advancedcluster/resource_advanced_cluster_migration_test.go b/internal/service/advancedcluster/resource_advanced_cluster_migration_test.go
@@ -25,14 +25,7 @@ func TestMigAdvancedCluster_singleAWSProvider(t *testing.T) {
 			{
 				ExternalProviders: mig.ExternalProviders(),
 				Config:            config,
-				Check: resource.ComposeTestCheckFunc(
-					checkExists(resourceName),
-					resource.TestCheckResourceAttrSet(resourceName, "project_id"),
-					resource.TestCheckResourceAttr(resourceName, "name", clusterName),
-					resource.TestCheckResourceAttr(resourceName, "retain_backups_enabled", "true"),
-					resource.TestCheckResourceAttrSet(resourceName, "replication_specs.#"),
-					resource.TestCheckResourceAttrSet(resourceName, "replication_specs.0.region_configs.#"),
-				),
+				Check:             checkSingleProvider(projectID, clusterName),
 			},
 			mig.TestStepCheckEmptyPlan(config),
 		},
@@ -54,14 +47,7 @@ func TestMigAdvancedCluster_multiCloud(t *testing.T) {
 			{
 				ExternalProviders: mig.ExternalProviders(),
 				Config:            config,
-				Check: resource.ComposeTestCheckFunc(
-					checkExists(resourceName),
-					resource.TestCheckResourceAttrSet(resourceName, "project_id"),
-					resource.TestCheckResourceAttr(resourceName, "name", clusterName),
-					resource.TestCheckResourceAttr(resourceName, "retain_backups_enabled", "false"),
-					resource.TestCheckResourceAttrSet(resourceName, "replication_specs.#"),
-					resource.TestCheckResourceAttrSet(resourceName, "replication_specs.0.region_configs.#"),
-				),
+				Check:             checkMultiCloud(clusterName, 3),
 			},
 			mig.TestStepCheckEmptyPlan(config),
 		},
@@ -110,7 +96,7 @@ func TestMigAdvancedCluster_partialAdvancedConf(t *testing.T) {
 			{
 				ExternalProviders: mig.ExternalProviders(),
 				Config:            config,
-				Check: resource.ComposeTestCheckFunc(
+				Check: resource.ComposeAggregateTestCheckFunc(
 					checkExists(resourceName),
 					resource.TestCheckResourceAttr(resourceName, "advanced_configuration.0.fail_index_key_too_long", "false"),
 					resource.TestCheckResourceAttr(resourceName, "advanced_configuration.0.javascript_enabled", "true"),
@@ -123,7 +109,7 @@ func TestMigAdvancedCluster_partialAdvancedConf(t *testing.T) {
 			{
 				ProtoV6ProviderFactories: acc.TestAccProviderV6Factories,
 				Config:                   configUpdated,
-				Check: resource.ComposeTestCheckFunc(
+				Check: resource.ComposeAggregateTestCheckFunc(
 					checkExists(resourceName),
 					resource.TestCheckResourceAttr(resourceName, "advanced_configuration.0.fail_index_key_too_long", "false"),
 					resource.TestCheckResourceAttr(resourceName, "advanced_configuration.0.javascript_enabled", "true"),