Skip to content

Commit

Permalink
remove unnecessary CI var
Browse files Browse the repository at this point in the history
  • Loading branch information
oarbusi committed Jan 7, 2025
1 parent da8002c commit 06570e6
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 7 deletions.
4 changes: 0 additions & 4 deletions .github/workflows/acceptance-tests-runner.yml
Original file line number Diff line number Diff line change
Expand Up @@ -98,9 +98,6 @@ on:
mongodb_atlas_flex_project_id:
type: string
required: true
mongodb_atlas_stream_aws_pl_project_id:
type: string
required: true
confluent_cloud_network_id:
type: string
required: true
Expand Down Expand Up @@ -1074,7 +1071,6 @@ jobs:
AWS_ACCOUNT_ID: ${{ secrets.aws_account_id }}
CONFLUENT_CLOUD_API_KEY: ${{ secrets.confluent_cloud_api_key }}
CONFLUENT_CLOUD_API_SECRET: ${{ secrets.confluent_cloud_api_secret }}
MONGODB_ATLAS_STREAM_AWS_PL_PROJECT_ID: ${{ inputs.mongodb_atlas_stream_aws_pl_project_id }}
CONFLUENT_CLOUD_NETWORK_ID: ${{ inputs.confluent_cloud_network_id }}
CONFLUENT_CLOUD_PRIVATELINK_ACCESS_ID: ${{ inputs.confluent_cloud_privatelink_access_id }}
ACCTEST_PACKAGES: |
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/acceptance-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,5 @@ jobs:
azure_private_endpoint_region: ${{ vars.AZURE_PRIVATE_ENDPOINT_REGION }}
mongodb_atlas_rp_org_id: ${{ inputs.atlas_cloud_env == 'qa' && vars.MONGODB_ATLAS_RP_ORG_ID_QA || vars.MONGODB_ATLAS_RP_ORG_ID_DEV }}
mongodb_atlas_flex_project_id: ${{ inputs.atlas_cloud_env == 'qa' && vars.MONGODB_ATLAS_FLEX_PROJECT_ID_QA || vars.MONGODB_ATLAS_FLEX_PROJECT_ID }}
mongodb_atlas_stream_aws_pl_project_id: ${{ inputs.atlas_cloud_env == 'qa' && vars.MONGODB_ATLAS_STREAM_AWS_PL_PROJECT_ID_QA || vars.MONGODB_ATLAS_STREAM_AWS_PL_PROJECT_ID }}
confluent_cloud_network_id: ${{ vars.CONFLUENT_CLOUD_NETWORK_ID }}
confluent_cloud_privatelink_access_id: ${{ vars.CONFLUENT_CLOUD_PRIVATELINK_ACCESS_ID }}
3 changes: 1 addition & 2 deletions internal/testutil/acc/pre_check.go
Original file line number Diff line number Diff line change
Expand Up @@ -367,9 +367,8 @@ func PreCheckConfluentAWSPrivatelink(tb testing.TB) {
tb.Helper()
if os.Getenv("CONFLUENT_CLOUD_API_KEY") == "" ||
os.Getenv("CONFLUENT_CLOUD_API_SECRET") == "" ||
os.Getenv("MONGODB_ATLAS_STREAM_AWS_PL_PROJECT_ID") == "" ||
os.Getenv("CONFLUENT_CLOUD_NETWORK_ID") == "" ||
os.Getenv("CONFLUENT_CLOUD_PRIVATELINK_ACCESS_ID") == "" {
tb.Fatal("`CONFLUENT_CLOUD_API_KEY`, `CONFLUENT_CLOUD_API_SECRET`, `MONGODB_ATLAS_STREAM_AWS_PL_PROJECT_ID`, `CONFLUENT_CLOUD_NETWORK_ID`, and `CONFLUENT_CLOUD_PRIVATELINK_ACCESS_ID` must be set for Cloud Backup Snapshot Export Bucket acceptance testing")
tb.Fatal("`CONFLUENT_CLOUD_API_KEY`, `CONFLUENT_CLOUD_API_SECRET`, `CONFLUENT_CLOUD_NETWORK_ID`, and `CONFLUENT_CLOUD_PRIVATELINK_ACCESS_ID` must be set for Cloud Backup Snapshot Export Bucket acceptance testing")
}
}

0 comments on commit 06570e6

Please sign in to comment.