Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOP-5303: Handle ast file facets in postprocessor #642

Merged
merged 3 commits into from
Jan 27, 2025

Conversation

rayangler
Copy link
Collaborator

@rayangler rayangler commented Jan 22, 2025

Ticket

DOP-5303

Notes

  • There was an additional change that needed to be done to allow facets to be propagated properly to ast files.

To test:

  1. Go to this staging link
  2. Open up dev tools and go to the network tab.
  3. Look for page-data.json for the current staged page. Navigate to result.data.page.facets and the repo-wide facets should now be there, along with the new "reference" genre facet.

README updates

    • This PR introduces changes that should be reflected in the README.md and/or HACKING.md, and I have made those updates.
    • This PR does not introduce changes that should be reflected in the README.md and/or HACKING.md

Copy link
Collaborator

@mmeigs mmeigs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@rayangler rayangler merged commit 2ba426b into main Jan 27, 2025
5 checks passed
@rayangler rayangler deleted the DOP-5303-ast-facets branch January 27, 2025 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants