Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOP-4562: new link-new-tab role #632

Merged
merged 1 commit into from
Nov 12, 2024
Merged

DOP-4562: new link-new-tab role #632

merged 1 commit into from
Nov 12, 2024

Conversation

mmeigs
Copy link
Collaborator

@mmeigs mmeigs commented Nov 12, 2024

Ticket

DOP-4962

Notes

New role to enable opening link in new tab.

README updates

    • This PR introduces changes that should be reflected in the README.md and/or HACKING.md, and I have made those updates.
    • This PR does not introduce changes that should be reflected in the README.md and/or HACKING.md

@mmeigs mmeigs requested review from i80and and rayangler November 12, 2024 17:16
i80and
i80and approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@i80and i80and left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Metal 🤘🏻

@mmeigs mmeigs merged commit 7c908e9 into main Nov 12, 2024
5 checks passed
@mmeigs mmeigs deleted the DOP-4562-new-tab branch November 12, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@i80and i80and i80and approved these changes

@rayangler rayangler rayangler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mmeigs @i80and @rayangler