Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOP-4945: Default tab available for drivers tabs #629

Merged
merged 6 commits into from
Nov 11, 2024
Merged

DOP-4945: Default tab available for drivers tabs #629

merged 6 commits into from
Nov 11, 2024

Conversation

mmeigs
Copy link
Collaborator

@mmeigs mmeigs commented Nov 7, 2024 •
edited
Loading

Ticket

DOP-4945

Notes

New optional option :default-tabid: for tabs-selector and tabs-pillstrip directives for use with drivers tabs.

Staging links available on sister PR in snooty here.

README updates

    • This PR introduces changes that should be reflected in the README.md and/or HACKING.md, and I have made those updates.
    • This PR does not introduce changes that should be reflected in the README.md and/or HACKING.md

@mmeigs mmeigs mentioned this pull request Nov 7, 2024
Merged
@mmeigs mmeigs requested review from seungpark and rayangler November 7, 2024 16:49
seungpark
seungpark reviewed Nov 7, 2024
View reviewed changes
Copy link
Collaborator

@seungpark seungpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all those back and forth's of default tab 🙌

rayangler
rayangler reviewed Nov 7, 2024
View reviewed changes
@mmeigs mmeigs requested review from rayangler and seungpark November 7, 2024 21:32
seungpark
seungpark reviewed Nov 8, 2024
View reviewed changes
Copy link
Collaborator

@seungpark seungpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two minor comments but otherwise LGTM !

@mmeigs mmeigs requested a review from seungpark November 8, 2024 16:18
seungpark
seungpark approved these changes Nov 8, 2024
View reviewed changes
Copy link
Collaborator

@seungpark seungpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! thanks for explaining above !

rayangler
rayangler reviewed Nov 11, 2024
View reviewed changes
@mmeigs mmeigs merged commit 00c3a2d into main Nov 11, 2024
5 checks passed
@mmeigs mmeigs deleted the DOP-4945-chosen-tab branch November 11, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rayangler rayangler rayangler left review comments

@seungpark seungpark seungpark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mmeigs @seungpark @rayangler