fix(NODE-6249): prevent make invocation on falsy responseType

[fredmaggiowski]

Description

By NODE-6249 we are receiving a TypeError in the changeStream.on('error') handler:

TypeError: responseType ?? responses_1.MongoDBResponse).make is not a function

This TypeError can occur either because:

• responseType is falsy (but not nullish); or
• an unexpected responseType that doesn't fit the MongoDBResponseConstructor type is received

What is changing?

This PR proposes a change that makes the (responseType/MongoDBResponse).make() more robust, by falling-back to MongoDBResponse on all the falsy values rather than only the nullish ones.

Is there new documentation needed for these changes?

don't think so

What is the motivation for this change?

As said above, we are receiving a TypeError that feels a lot like a programming error; this may help mitigate the issue; I couldn't find a way (if given some help/insight I can try and further investigate) to understand the actual value for responseType.

Release Highlight

Fixed change stream cursor error bug that may result in receiving a TypeError

Double check the following

• Ran npm run check:lint script
• Self-review completed using the steps outlined here
• PR title follows the correct format: type(NODE-xxxx)[!]: description
  • Example: feat(NODE-1234)!: rewriting everything in coffeescript
• Changes are covered by tests
• New TODOs have a related JIRA ticket

[fredmaggiowski]

I found out the issue was related to an incompatibility between mongodb driver 6.8.0 and @opentelemetry/instrumentation-mongodb <0.46.0: open-telemetry/opentelemetry-js-contrib#2314

Updating the latter, the bug stopped happening