fix(NODE-5745): Ignore Read/Write Concern in Atlas Search Index Helpers

[aditi-khare-mongoDB]

Description

Synced tests and remove r/w concern from relevant method's options value.

What is changing?

Added spec tests to ensure readConcern and writeConcern are not sent to command with Atlas Search Helpers.
Explicitly remove readConcern and writeConcern from Collection.listSearchIndexes.

Is there new documentation needed for these changes?

No.

What is the motivation for this change?

Spec compliance.

Release Highlight

Omit readConcern and writeConcern in Collection.listSearchIndexes options argument

Important

readConcern and writeConcern are no longer viable keys in the options argument passed into Collection.listSearchIndexes

This type change is a correctness fix.

Collection.listSearchIndexes is an Atlas specific method, and Atlas' search indexes do not support readConcern and writeConcern options. The types for this function now reflect this functionality.

Double check the following

• Ran npm run check:lint script
• Self-review completed using the steps outlined here
• PR title follows the correct format: type(NODE-xxxx)[!]: description
  • Example: feat(NODE-1234)!: rewriting everything in coffeescript
• Changes are covered by tests
• New TODOs have a related JIRA ticket

[nbbeeken]

Is this a feature? it doesn't modify any driver source. What about the txn unknown mentioned in the ticket? (Are txn's even relevant?)

[aditi-khare-mongoDB]

There's a small code change, I mistakenly marked this as Ready for Review preemptively, but it is ready for review now. I'm not sure how transactions are relevant, since we never pass wr concern into the command anyway.

[nbbeeken]

Transactions are controlled by the session, if a session is in a transaction it will apply the transaction's wc/rc settings, so how are we handling that? Do we need to handle that?

[nbbeeken]

Is this really a feat? shouldn't it be a fix?