ci(NODE-5652): move vars to expansions #3877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbbeeken
force-pushed
the
NODE-5652-ci-vars
branch
from
c88c09e to
6ff084b
Compare
baileympearson
previously approved these changes
Oct 2, 2023
|
|
||
| const TASKS = []; | ||
| const SINGLETON_TASKS = []; | ||
|
|
||
| /** Accepts {key: value} -> returns {key, value}[] */ | ||
| function updateExpansions(expansions) { |
baileympearson
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
varsto expansionsadd_expansions_to_env: trueNote to reviewer it is easier to follow changes per commit to skip over misc formatting fixes
Is there new documentation needed for these changes?
No
What is the motivation for this change?
Avoiding use of var removes the risk of breakages when evergreen removes the behavior where vars persist across functions
Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript