-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(NODE-5188): add alternative runtime detection to client metadata #3636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Server log lines: {"t":{"$date":"2023-04-12T15:53:58.738-04:00"},"s":"I", "c":"NETWORK", "id":51800, "ctx":"conn6","msg":"client metadata","attr":{"remote":"127.0.0.1:64794","client":"conn6","doc":{"driver":{"name":"nodejs","version":"5.2.0"},
"platform":"Deno v1.32.3, LE",
"os":{"name":"darwin","architecture":"arm64","version":"22.4.0","type":"Darwin"}}}}
{"t":{"$date":"2023-04-12T16:03:31.216-04:00"},"s":"I", "c":"NETWORK", "id":51800, "ctx":"conn18","msg":"client metadata","attr":{"remote":"127.0.0.1:59421","client":"conn18","doc":{"driver":{"name":"nodejs","version":"5.2.0"},
"platform":"Bun v0.5.4, LE",
"os":{"name":"darwin","architecture":"arm64","version":"22.4.0","type":"Darwin"}}}} |
alexbevi
previously approved these changes
Apr 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
durran
added
the
Primary Review
In Review with primary reviewer, not yet ready for team's eyes
label
Apr 13, 2023
durran
requested changes
Apr 13, 2023
nbbeeken
commented
Apr 13, 2023
baileympearson
approved these changes
Apr 13, 2023
durran
requested changes
Apr 13, 2023
durran
approved these changes
Apr 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
Changes platform metadata based on globals in the driver's runtime environement.
What is the motivation for this change?
Node.js compatibility in Deno and Bun have made it possible to run the driver, it is useful to denote the difference between the runtimes in the platform information.
Double check the following
npm run check:lint
scripttype(NODE-xxxx)[!]: description
feat(NODE-1234)!: rewriting everything in coffeescript