Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: pull in misc CI fixes for the 4x branch #3536

Merged
merged 3 commits into from
Jan 23, 2023
Merged

ci: pull in misc CI fixes for the 4x branch #3536

merged 3 commits into from
Jan 23, 2023

Conversation

baileympearson
Copy link
Contributor

@baileympearson baileympearson commented Jan 23, 2023

Description

Collection of fixes needed for 4x CI.

A more exhaustive CI run is here - https://spruce.mongodb.com/version/63cef18c3e8e860af2ccf52f/tasks?sorts=STATUS%3AASC%3BBASE_STATUS%3ADESC. Some tests still fail but with usual flaky test failures, not with CI configuration issues.

What is changing?

Is there new documentation needed for these changes?

What is the motivation for this change?

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@baileympearson baileympearson marked this pull request as ready for review January 23, 2023 21:08
@baileympearson baileympearson changed the title ci(NODE-4881): adjust tests to pass on Node18 (#3485) ci(no-story): pull in misc CI fixes for the 4x branch Jan 23, 2023
@dariakp dariakp changed the title ci(no-story): pull in misc CI fixes for the 4x branch ci: pull in misc CI fixes for the 4x branch Jan 23, 2023
@dariakp dariakp merged commit 4c49b2e into 4.x Jan 23, 2023
@dariakp dariakp deleted the ci-fixes branch January 23, 2023 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants