feat(NODE-4817)!: remove legacy logger #3518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
W-A-James
force-pushed
the
NODE-4817/remove-legacy-logger
branch
2 times, most recently
from
bb0ed91 to
055c4b3
Compare
durran
requested changes
Jan 19, 2023
durran
added
the
Primary Review
W-A-James
force-pushed
the
NODE-4817/remove-legacy-logger
branch
from
1bb04e7 to
f99a285
Compare
W-A-James
commented
Jan 19, 2023
W-A-James
commented
Jan 19, 2023
durran
requested changes
Jan 19, 2023
durran
requested changes
Jan 20, 2023
W-A-James
commented
Jan 20, 2023
src/sdam/srv_polling.ts
Outdated
| this.logger.error(`Unexpected ${new MongoRuntimeError(unexpectedRuntimeError).stack}`); | ||
| }); | ||
| // eslint-disable-next-line @typescript-eslint/no-empty-function, @typescript-eslint/no-unused-vars | ||
| this._poll().catch(_unexpectedRuntimeError => {}); |
There was a problem hiding this comment.
From slack discussion, don't want to remove this as we don't want to have an unhandled promise, so we can just swallow it here.
There was a problem hiding this comment.
Can you change this to ()=>null it matches the rest of our catch and release promise handling.
There was a problem hiding this comment.
we can drop the underscore argument
|
https://spruce.mongodb.com/version/63caf4e1e3c3310b2e31edee/tasks?sorts=STATUS%3AASC%3BBASE_STATUS%3ADESC |
dariakp
removed
the
Primary Review
dariakp
reviewed
Jan 20, 2023
5 tasks
…ode-mongodb-native into NODE-4817/remove-legacy-logger
nbbeeken
changed the title
nbbeeken
requested changes
Jan 23, 2023
src/sdam/srv_polling.ts
Outdated
| @@ -106,15 +103,14 @@ export class SrvPoller extends TypedEventEmitter<SrvPollerEvents> { | |||
| } | |||
| } | |||
|
|
|||
| // TODO(NODE-4817): This method has been left to allow for refactoring with the new logger | |||
There was a problem hiding this comment.
TODOs normally refer to tickets that haven't been done yet so we can find the relevant code again. I think this should probably be something in the new spec-ed logger epic
dariakp
approved these changes
Jan 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removing references to the legacy
Loggerclass in preparation for the implementation and installation of the newMongoLoggerIs there new documentation needed for these changes?
No
Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript