feat(NODE-4925)!: remove deprecated options and types #3513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baileympearson
force-pushed
the
no-story-asdf
branch
from
b1b2043 to
f061d85
Compare
baileympearson
force-pushed
the
no-story-asdf
branch
from
f061d85 to
b98e029
Compare
baileympearson
commented
Jan 4, 2023
| @@ -670,21 +670,7 @@ describe('CRUD API', function () { | |||
| // Legacy update method | |||
| // ------------------------------------------------- | |||
| const legacyRemove = function () { | |||
| db.collection('t4_1').insertMany( | |||
There was a problem hiding this comment.
Removing the single option necessitates refactoring this test to use deleteOne. There is already a test for deleteOne specifically, and we're removing remove in another PR, so removing this block of code felt like the correct approach.
baileympearson
commented
Jan 4, 2023
| @@ -107,52 +107,6 @@ describe('Remove', function () { | |||
| } | |||
| }); | |||
|
|
|||
| it('should correctly remove only first document', { | |||
There was a problem hiding this comment.
Similar to above, removing single means this test no longer passes. To make this test pass, we would rework it to use deleteOne, but deleteOne is tested elsewhere.
baileympearson
changed the title
nbbeeken
added
the
Primary Review
nbbeeken
requested changes
Jan 5, 2023
Co-authored-by: Neal Beeken <neal.beeken@mongodb.com>
|
not sure why the patch isn't being picked up - it's here https://spruce.mongodb.com/version/63b6e8e3a4cf470aa9f8def7/tasks?sorts=STATUS%3AASC%3BBASE_STATUS%3ADESC |
nbbeeken
requested changes
Jan 5, 2023
nbbeeken
approved these changes
Jan 5, 2023
nbbeeken
removed
the
Primary Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
This PR removes the following deprecated options and types:
Is there new documentation needed for these changes?
No.
Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript