fix(NODE-4621): ipv6 address handling in HostAddress #3410
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
NODE-4621
What is changing?
Always include brackets when getting the whole hostAddress string.
Connection
instances have the correct formatted address for ipv6new URL
it was very unclear only printing:TypeError: Invalid URL
prints the input hostname now and attaches the original error as a cause.this.configuration.options.hostAddresses
to not be nullishlocalhost
to::1
by default, Windows, does, and on macos we don't run replica_setsWhat is the motivation for this change?
When a port exists (which always does for us) you must include brackets for the whole host address
Double check the following
npm run check:lint
script<type>(NODE-xxxx)<!>: <description>