Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NODE-3986): unskip MONGODB-AWS test #3397

Merged
merged 4 commits into from
Sep 8, 2022
Merged

fix(NODE-3986): unskip MONGODB-AWS test #3397

merged 4 commits into from
Sep 8, 2022

Conversation

biniona-mongodb
Copy link
Contributor

@biniona-mongodb biniona-mongodb commented Sep 4, 2022 •
edited
Loading

Description

Update driver to throw exception when the following conditions are met:

  • Using MONGODB-AWS auth mechanism
  • A username is provided
  • A password is not provided

What is changing?

Adding check to see if preceding conditions are met when constructing mongoOptions object.

Unskip test that checks this behavior.

Is there new documentation needed for these changes?

No

What is the motivation for this change?

NODE-3986

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: <type>(NODE-xxxx)<!>: <description>
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@biniona-mongodb biniona-mongodb changed the title test(NODE-3986): test(NODE-3986): Check username and no password for MONGODB-AWS auth mechanism Sep 4, 2022
@biniona-mongodb biniona-mongodb changed the title test(NODE-3986): Check username and no password for MONGODB-AWS auth mechanism test(NODE-3986): Check username and no password for MONGODB-AWS Sep 4, 2022
@biniona-mongodb biniona-mongodb changed the title test(NODE-3986): Check username and no password for MONGODB-AWS test(NODE-3986): unskip MONGODB-AWS test Sep 4, 2022
@biniona-mongodb biniona-mongodb marked this pull request as ready for review September 4, 2022 18:51
@durran durran added tracked-in-jira Ticket filed in MongoDB's Jira system Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Sep 5, 2022
durran
durran reviewed Sep 5, 2022
View reviewed changes
src/connection_string.ts Outdated Show resolved Hide resolved
durran
durran requested changes Sep 5, 2022
View reviewed changes
Copy link
Member

@durran durran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggesting small wording change.

dariakp
dariakp requested changes Sep 6, 2022
View reviewed changes
src/connection_string.ts Outdated Show resolved Hide resolved
@dariakp dariakp changed the title test(NODE-3986): unskip MONGODB-AWS test fix(NODE-3986): unskip MONGODB-AWS test Sep 6, 2022
@biniona-mongodb biniona-mongodb requested review from dariakp and durran and removed request for durran and dariakp September 6, 2022 14:46
@durran durran merged commit 5676f81 into mongodb:main Sep 8, 2022
@biniona-mongodb biniona-mongodb mentioned this pull request Sep 11, 2022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dariakp dariakp dariakp approved these changes

@durran durran durran approved these changes

Assignees
No one assigned
Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes tracked-in-jira Ticket filed in MongoDB's Jira system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@biniona-mongodb @durran @dariakp