feat(NODE-4139): streaming protocol message changes #3256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the monitor detects it is using the streaming protocol we now tell the message stream to only ever emit the last message in the buffer.
dariakp
requested changes
May 19, 2022
jyemin
requested changes
May 19, 2022
|
Seem to all be around 300-400ms now. |
jyemin
requested changes
May 20, 2022
dariakp
requested changes
May 20, 2022
jyemin
reviewed
May 23, 2022
dariakp
requested changes
May 23, 2022
dariakp
approved these changes
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Only emits the last message from the message stream's buffer when using the streaming protocol.
What is changing?
The monitor will now tell the connection that it's using the streaming protocol, which in turn will
set the flag on the connection's message stream. When the stream is in this mode, it will only ever
emit the message event with the very last message in the buffer pool. So if there's more data in the
buffer, the stream essentially skips its emit.
Is there new documentation needed for these changes?
None
What is the motivation for this change?
NODE-4139
Double check the following
npm run check:lintscript<type>(NODE-xxxx)<!>: <description>