fix(NODE-3688): make handshake errors retryable #3165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
durran
force-pushed
the
NODE-3688
branch
3 times, most recently
from
87472cd to
c9d9277
Compare
durran
added
Primary Review
durran
force-pushed
the
NODE-3688
branch
5 times, most recently
from
d9a3a5c to
0295f5f
Compare
durran
added
Primary Review
dariakp
requested changes
Mar 15, 2022
There was a problem hiding this comment.
Just a couple of organizational notes; I verified the synced spec files but I haven't fully reviewed the actual manual implementations of the spec tests yet, I wanted to hear your thoughts on the potential alternate approach in case it actually makes things easier
test/integration/retryable-reads/retryable_reads.prose.spec.test.ts
Outdated
Show resolved
Hide resolved
test/integration/retryable-writes/retryable_writes.spec.test.ts
Outdated
Show resolved
Hide resolved
test/integration/retryable-writes/retryable_writes.spec.prose.test.ts
Outdated
Show resolved
Hide resolved
dariakp
added
Team Review
dariakp
requested changes
Mar 17, 2022
dariakp
changed the title
dariakp
requested changes
Mar 18, 2022
test/integration/retryable-writes/retryable_writes.spec.test.ts
Outdated
Show resolved
Hide resolved
test/integration/retryable-writes/retryable_writes.spec.test.ts
Outdated
Show resolved
Hide resolved
dariakp
previously approved these changes
Mar 22, 2022
baileympearson
requested changes
Mar 23, 2022
|
@nbbeeken What I've ended up doing here (since there are a few old stale comments) is adding a label to the handshake error, and then ensuring that if we are 4.4 and higher we don't add any additional labels except in the case where that label exists. This covers all the cases and all spec tests are passing. My changes to the spec tests are now removed. |
nbbeeken
approved these changes
Apr 21, 2022
baileympearson
approved these changes
Apr 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Makes operations retryable when the handshake fails.
What is changing?
Is there new documentation needed for these changes?
No
What is the motivation for this change?
NODE-3688
Notes
After syncing tests there were some extras that sneaked in:
This PR also syncs retryable writes unified tests from NODE-3733/DRIVERS-1385 that were missed in that work.
This PR also syncs transaction unified tests from DRIVERS-1539 that did not get individual language tickets.
Double check the following
npm run check:lintscript<type>(NODE-xxxx)<!>: <description>