-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(NODE-3698): sync spec tests for crud operations with let
option
#3147
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@baileympearson Did you double check that our unified test runner definitely and correctly parses the specified let option input and expectations? (I know we made the runner adjustments in the original PR, but I am a bit paranoid about these things after all the misses we've discovered after the fact, so always worth a second look)
@dariakp yes, I've confirmed that the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small issue with whitespaces, otherwise LGTM
Description
What is changing?
Support for the
let
option was added in: #2829This PR pulls in spec changes from the following PRs:
Is there new documentation needed for these changes?
No
Double check the following
npm run check:lint
script<type>(NODE-xxxx)<!>: <description>