fix(NODE-3767): don't delete dbName if authSource is provided #3055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good job, I faced this issue too when upgrading to 4.2.0. |
nbbeeken
changed the title
4 tasks
nbbeeken
previously approved these changes
Nov 29, 2021
nbbeeken
added
External Submission
dariakp
approved these changes
Nov 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
dbNameoption is not going to be deleted whenauthSourceis present in the connection string.Is there new documentation needed for these changes?
I don't think there is unless this is intentional behaviour.
What is the motivation for this change?
I have noticed that the
dbNameoption is deleted whenauthSourceis being passed in the connection string since version 4.2.0 (after this commit) but I couldn't find any documentation for this neither the MongoDB documentation nor in the MongoDB driver documentation. I thought that this might be a bug since according to those documentations mentioned above, there's no colliding betweendbNameandauthSourceand currently both options are allowed.