Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(NODE-3157)!: update find and modify interfaces for 4.0 #2799

Merged
merged 7 commits into from
May 7, 2021

Conversation

dariakp
Copy link
Contributor

@dariakp dariakp commented May 5, 2021

Description

What changed?
BREAKING: Legacy fields option no longer supported, use projection instead.

NODE-3157 Updated public facing option interfaces for find and modify operations: findOneAndDelete(), findOneAndReplace(), findOneAndUpdate(). Standardized option parsing and internal representation of find and modify operations.

@dariakp dariakp marked this pull request as ready for review May 5, 2021 18:45
@dariakp dariakp requested review from a team, durran, emadum and nbbeeken and removed request for a team May 5, 2021 18:45
@dariakp dariakp changed the title refactor(NODE-3157)!: Remove legacy fields property from FindAndModifyOptions refactor(NODE-3157)!: update find and modify interfaces for 4.0 May 5, 2021
@dariakp
Copy link
Contributor Author

dariakp commented May 5, 2021

Reviewers: please compare #2796 for the "light" version of these changes

Copy link
Member

@durran durran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and nice work. I prefer this to the "light" changes. :)

Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 nice refactor!

@dariakp dariakp merged commit 29512da into 4.0 May 7, 2021
@dariakp dariakp deleted the NODE-3157/update-find-and-modify-interfaces-for-4.0-v2 branch May 7, 2021 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants