feat(NODE-4509): send 1 with hello commands

mongodb · Jan 3, 2023 · ec0175f · ec0175f
1 parent b4e63fb
commit ec0175f
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/src/cmap/connect.ts b/src/cmap/connect.ts
@@ -231,7 +231,7 @@ export function prepareHandshakeDocument(
   const { serverApi } = authContext.connection;
 
   const handshakeDoc: HandshakeDocument = {
-    [serverApi?.version ? 'hello' : LEGACY_HELLO_COMMAND]: true,
+    [serverApi?.version ? 'hello' : LEGACY_HELLO_COMMAND]: 1,
     helloOk: true,
     client: options.metadata || makeClientMetadata(options),
     compression: compressors

diff --git a/src/sdam/monitor.ts b/src/sdam/monitor.ts
@@ -238,7 +238,7 @@ function checkServer(monitor: Monitor, callback: Callback<Document | null>) {
     const isAwaitable = topologyVersion != null;
 
     const cmd = {
-      [serverApi?.version || helloOk ? 'hello' : LEGACY_HELLO_COMMAND]: true,
+      [serverApi?.version || helloOk ? 'hello' : LEGACY_HELLO_COMMAND]: 1,
       ...(isAwaitable && topologyVersion
         ? { maxAwaitTimeMS, topologyVersion: makeTopologyVersion(topologyVersion) }
         : {})

diff --git a/test/integration/mongodb-handshake/promise_handshake.test.js b/test/integration/mongodb-handshake/promise_handshake.test.js
@@ -28,7 +28,7 @@ describe('Handshake', function () {
         // Execute legacy hello command
         client
           .db(configuration.db)
-          .command({ [LEGACY_HELLO_COMMAND]: true })
+          .command({ [LEGACY_HELLO_COMMAND]: 1 })
           .then(function (result) {
             test.ok(result !== null);