fix: don't throw if withTransaction() callback rejects with a null …

…reason A logical error prevented receipt of errors returned from the lambda passed into the `withTransaction` helper. NODE-2515
mongodb · Apr 2, 2020 · 153646c · 153646c
1 parent 7778977
commit 153646c
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 0 deletions.
diff --git a/lib/core/sessions.js b/lib/core/sessions.js
@@ -304,6 +304,7 @@ function isUnknownTransactionCommitResult(err) {
 }
 
 function isMaxTimeMSExpiredError(err) {
+  if (err == null) return false;
   return (
     err.code === MAX_TIME_MS_EXPIRED_CODE ||
     (err.writeConcernError && err.writeConcernError.code === MAX_TIME_MS_EXPIRED_CODE)

diff --git a/test/functional/transactions.test.js b/test/functional/transactions.test.js
@@ -75,6 +75,23 @@ describe('Transactions', function() {
         session.endSession(done);
       }
     });
+
+    it('should return readable error if promise rejected with no reason', {
+      metadata: { requires: { topology: ['replicaset', 'sharded'], mongodb: '>=4.0.2' } },
+      test: function(done) {
+        function fnThatReturnsBadPromise() {
+          return Promise.reject();
+        }
+
+        session
+          .withTransaction(fnThatReturnsBadPromise)
+          .then(() => done(Error('Expected error')))
+          .catch(err => {
+            expect(err).to.equal(undefined);
+            session.endSession(done);
+          });
+      }
+    });
   });
 
   describe('startTransaction', function() {