Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOP-3948 #64

Merged
merged 4 commits into from
Aug 17, 2023
Merged

DOP-3948 #64

merged 4 commits into from
Aug 17, 2023

Conversation

seungpark
Copy link
Contributor

@seungpark seungpark commented Aug 15, 2023

DOP-3948

Goal: Convert page documents from parser into manifest entries for search.documents[], namely the "facets" field

Example of output page documents from parser is included in the ticket.
Updated bson includes an update to the expected page document:

{
	"page_id": "cloud-docs/seung.park/DOP-3851-b-test-facet-directives/reference/google-gcp",
	"filename": "reference/google-gcp.txt",
	"ast": {...},
	"source": "",
	"static_assets": [...],
	"facets": [
		{
			"category": "programming_language",
			"value": "cpp",
			"sub_facets": null
		},
		{
			"category": "genre",
			"value": "reference",
			"sub_facets": null
		},
		{
			"category": "target_product",
			"value": "atlas",
			"sub_facets": [
				{
					"category": "sub_product",
					"value": "search",
					"sub_facets": null
				}
			]
		}
	]
}

@seungpark seungpark marked this pull request as ready for review August 15, 2023 21:20
Copy link
Collaborator

@i80and i80and left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple syntax notes

mut/index/SnootyManifest.py Outdated Show resolved Hide resolved
mut/index/SnootyManifest.py Outdated Show resolved Hide resolved
mut/index/SnootyManifest.py Outdated Show resolved Hide resolved
mut/index/SnootyManifest.py Outdated Show resolved Hide resolved
@seungpark seungpark requested a review from i80and August 16, 2023 22:08
Copy link
Contributor

@rayangler rayangler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@seungpark seungpark merged commit 9345b02 into master Aug 17, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants