MOTOR-1209: Motor's DriverInfo should not be overwritten #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShaneHarvey
requested changes
Nov 8, 2023
ShaneHarvey
requested changes
Nov 9, 2023
| client = motor.MotorClient(server.uri, driver=driver_info) | ||
|
|
||
| # Trigger connection. | ||
| future = client.db.command("ping") |
There was a problem hiding this comment.
Is this needed? IIUC the ismaster is from SDAM which happens automatically so this future could be removed.
There was a problem hiding this comment.
Ah, I wasn't sure if it was needed. I assumed that the ping was the source.
There was a problem hiding this comment.
Yeah, I tried removing the ping call, and the test now crashes with asyncio.exceptions.TimeoutError: Operation timed out after 5 seconds
ShaneHarvey
requested changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://jira.mongodb.org/browse/MOTOR-1209