-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: INTMDB 1005 Serverless private endpoint #669
feat: INTMDB 1005 Serverless private endpoint #669
Conversation
@Adelmar92 we need to add contract testing as well. |
@Adelmar92 Could you please include a manual QA/testing guide as well when adding any new features? The idea is that testing/any manual setup required for testing should be clearly outlined, this would help us in later automating all testing. |
Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LGTM |
Proposed changes
Added new resource Pirvate Endpoint Serverless:
Without AWS Private Endpoint Flow:
In this configuration, you have the flexibility to establish an Atlas private endpoint independently. By opting not to immediately connect it, you can manually set up the linkage with an AWS private endpoint or Azure. Simply set the CreateAndAssignAWSPrivateEndpoint attribute to false during resource creation.
With AWS Private Endpoint Flow:
For a streamlined experience, you can enable the automatic generation of both Atlas private and AWS private endpoints, along with their interconnection, all within a single resource. Achieve this by configuring the CreateAndAssignAWSPrivateEndpoint attribute as true and supplying the following configuration structure:
cfn testing:
stack testing:
Without aws Private endpoint
With aws Private endpoint
result:
atlas private endpoint
aws private endpoint
Jira ticket: INTMDB-1005
Type of change:
expected)
Manual QA performed:
Required Checklist:
make fmt
and formatted my codeworks in Atlas
Further comments