-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SERVER-80231: Add conditional statement for variable declaration #1560
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good work, some comments
Thanks for your comments |
Thanks for making this pull request! We just need you to create a new SERVER ticket on JIRA to help us track the PR. Linking https://jira.mongodb.org/browse/CXX-2708 will be great too. |
We're changed the existing ticket to SERVER-80231 (originally CXX-2708) to track this work, so no need to make a new ticket. |
Please fix he typos and recommit |
Just fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
The changes solve the minor issue reported here.