Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tidy sign_artifacts.sh #749

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Tidy sign_artifacts.sh #749

wants to merge 7 commits into from

Conversation

FGasper
Copy link
Contributor

@FGasper FGasper commented Jan 31, 2025 •
edited
Loading

This applies 3 changes:

  • Teach macos_notarize_and_sign() to fetch architecture-specific macnotary binaries. (Thus, if Rosetta breaks again, we won’t lose our ability to push builds.)
  • Fix shellcheck warnings.
  • Switch to long-form CLI args for podman.

@FGasper FGasper requested a review from shyam12860 February 4, 2025 21:07
@FGasper FGasper marked this pull request as ready for review February 4, 2025 21:17
@FGasper FGasper changed the title arch-specific mac notary Tidy sign_artifacts.sh Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shyam12860 shyam12860 Awaiting requested review from shyam12860

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@FGasper