-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace async_once
with tokio::sync::OnceCell
#992
Conversation
Thank you for contributing this! I've authorized an evergreen run and assuming that passes I'll merge this in. |
It looks like this doesn't compile with the |
I pushed an update:
|
Sorry, forgot that evergreen runs aren't publicly visible! Running
|
Pushed an update fixing the sync tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Tagging in Isabel.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks for your contribution!
async_once
is unmaintained and has been reported unsound.tokio
'sparking_lot
feature has been added in order to have access toOnceCell::const_new()
. This is only necessary in oldertokio
versions.