RUST-229 Parse IPv6 addresses in the connection string

[isabelatkinson]

No description provided.

[abr-egn]

LGTM! One nit, no need for re-review.

[abr-egn]

This is already inside the #[cfg(unix)] on line 213, so I don't think this is needed.

[abr-egn]

Similarly, I don't think this will ever trigger.

[pdhanoya]

@isabelatkinson The changes are incorrectly parsing localhost ipv6 "mongodb://[::1]:27017"; I had to add special checks for ipv6 localhost. Please ensure [::1] and [0:0:0:0:0:0:0:1] are parsed correctly.

[isabelatkinson]

The following test:

#[tokio::test]
async fn uri() {
    let uri = "mongodb://[::1]:27017";
    let options = ClientOptions::parse(uri).await.unwrap();
    dbg!("{}", options.hosts);

    let uri = "mongodb://[0:0:0:0:0:0:0:1]:27017";
    let options = ClientOptions::parse(uri).await.unwrap();
    dbg!("{}", options.hosts);
} 

gives me the following output:

[src/client/options/test.rs:369:5] "{}" = "{}"
[src/client/options/test.rs:369:5] options.hosts = [
    Tcp {
        host: "::1",
        port: Some(
            27017,
        ),
    },
]
[src/client/options/test.rs:373:5] "{}" = "{}"
[src/client/options/test.rs:373:5] options.hosts = [
    Tcp {
        host: "0:0:0:0:0:0:0:1",
        port: Some(
            27017,
        ),
    },
]

Is there a different output you're expecting?

Note that the ServerAddress::parse method only parses the "[::1]:27017" portion of the URI, so passing the entire URI to that method will fail.

[pdhanoya]

@isabelatkinson My local client fails like this when run with uri "mongodb://[::1]:27017";

    Finished `dev` profile [unoptimized + debuginfo] target(s) in 1.09s
     Running `target/debug/test_client`
Error: Error { kind: InvalidArgument { message: "port must be valid 16-bit unsigned integer, instead got: " }, labels: {}, wire_version: None, source: None }```

[isabelatkinson]

Based on that error message it doesn't look like you're working off the changes in the PR. What dependency do you have in your Cargo.toml file?

To test the PR changes you'll need:

mongodb = { git = "https://github.com/isabelatkinson/mongo-rust-driver", branch = "ipv6" } // plus any features you have enabled

(This is just a temporary change for testing; once we release you'll be able to depend on an official version again.)

[pdhanoya]

@isabelatkinson I was just behind a few commits after doing a pull.. I am able to test without issue and can confirm ipv6 localhost is working as expected.