Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUST-1813 Support named KMS providers #1141

Merged
merged 6 commits into from
Jun 24, 2024

Conversation

isabelatkinson
Copy link
Contributor

No description provided.

@isabelatkinson isabelatkinson marked this pull request as ready for review June 21, 2024 19:53
@isabelatkinson isabelatkinson requested a review from abr-egn June 21, 2024 19:53
Copy link
Contributor

@abr-egn abr-egn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! One extremely minor nit, no need for re-review.

@@ -193,57 +194,169 @@ impl ClientEncryption {
#[non_exhaustive]
#[allow(missing_docs)]
pub enum MasterKey {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the #[serde_with::skip_serializing_none] can be dropped from this now.

@isabelatkinson isabelatkinson merged commit 08e2923 into mongodb:main Jun 24, 2024
5 of 6 checks passed
@isabelatkinson isabelatkinson deleted the named-kms-providers branch June 24, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants