-
Notifications
You must be signed in to change notification settings - Fork 209
PHPC-2611 and PHPC-2626: Bump to libmongoc 2.1.0 and libmongocrypt 1.15.2 #1868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jmikola
wants to merge
6
commits into
mongodb:v2.x
Choose a base branch
from
jmikola:phpc-2611-libmongoc-2.1
base: v2.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alcaeus
reviewed
Sep 15, 2025
This pulls in changes from MONGOCRYPT-845, which are necessary to produce a static build with both libmongoc 2.1.0 and libmongocrypt (due to a conflict in the "mlib" headers).
7fe0f9e
to
3f7be27
Compare
alcaeus
approved these changes
Sep 16, 2025
3afb8f5
to
b0df958
Compare
990c7fe
to
a79eab9
Compare
Note: we've got two regularly failing builds on Windows 8.4 x86 (nts and ts) due to:
The most recent failures are at mongoc-handshake.c:702 but I'm not sure how pertinent that is. Will come back to this and investigate further. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/PHPC-2611
https://jira.mongodb.org/browse/PHPC-2626
The libmongocrypt upgrade is necessary due to a collision between "mlib" headers in libmongoc and libmongocrypt (addressed in MONGOCRYPT-845).