-
Notifications
You must be signed in to change notification settings - Fork 899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GODRIVER-2392 Remove all "import comments" on Go Driver packages #1498
Conversation
API Change Report./benchmarkincompatible changespackage removed ./cmd/build-oss-fuzz-corpusincompatible changespackage removed ./cmd/godriver-benchmarkincompatible changespackage removed ./cmd/parse-api-reportincompatible changespackage removed ./cmd/testatlasincompatible changespackage removed ./cmd/testawsincompatible changespackage removed ./cmd/testentauthincompatible changespackage removed ./cmd/testkmsincompatible changespackage removed ./eventincompatible changesCommandFailedEvent.DurationNanos: removed compatible changesConnectionCheckOutFailed: added ./examples/documentation_examplesincompatible changespackage removed ./mongoincompatible changes(*Client).Connect: removed compatible changesErrNotSlice: added ./mongo/descriptionincompatible changesSelectedServer.SessionTimeoutMinutes: changed from uint32 to *int64 ./mongo/gridfsincompatible changes(*Bucket).Delete: changed from func(interface{}) error to func(context.Context, interface{}) error compatible changesErrMissingChunk: added ./mongo/integrationincompatible changespackage removed ./mongo/optionsincompatible changes(*AggregateOptions).SetComment: changed from func(string) *AggregateOptions to func(interface{}) *AggregateOptions compatible changesDropCollection: added ./mongo/readconcernincompatible changes(*ReadConcern).GetLevel: removed ./mongo/writeconcernincompatible changes(*WriteConcern).GetJ: removed compatible changesWCMajority: added ./x/mongo/driverincompatible changesConnection.DriverConnectionID: changed from func() uint64 to func() int64 ./x/mongo/driver/drivertestincompatible changes(*ChannelConn).DriverConnectionID: changed from func() uint64 to func() int64 ./x/mongo/driver/mongocrypt/optionsincompatible changesMergeRewrapManyDataKeyOptions: removed ./x/mongo/driver/operationincompatible changes##(*Aggregate).Comment: changed from func(string) *Aggregate to func(./x/bsonx/bsoncore.Value) *Aggregate ./x/mongo/driver/sessionincompatible changesLoadBalancedTransactionConnection.DriverConnectionID: changed from func() uint64 to func() int64 ./x/mongo/driver/topologyincompatible changes(*Connection).DriverConnectionID: changed from func() uint64 to func() int64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
GODRIVER-2392
Summary
Remove all vestigial "import comments" from the Go Driver. See GODRIVER-2977 for the ticket for removing import comments from the BSON library.
Background & Motivation