GODRIVER-2416 Completely remove the 'x/bsonx' package. #1122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewdale
force-pushed
the
godriver2416-remove-bsonx
branch
3 times, most recently
from
2a2cde1
to
ade78f2
Compare
matthewdale
force-pushed
the
godriver2416-remove-bsonx
branch
from
ade78f2
to
7bd35d3
Compare
kevinAlbs
approved these changes
Nov 16, 2022
matthewdale
force-pushed
the
godriver2416-remove-bsonx
branch
from
b4eb57b
to
7d03a94
Compare
admpub
pushed a commit
to webx-top/qmgo
that referenced
this pull request
Nov 25, 2023
…qiniu#297) This package is gone after mongodb/mongo-go-driver#1122, which is included in mongo-go-driver v1.12.0. Replace the only usage site with the better supported equivalent.
|
You have released this breaking change in a "feature" release?! 1.11.7 -> 1.12.0?! Even your Jira ticket says it's supposed to be in version 2! There is no reference to breaking changes in the release notes either. This is not okay. |
|
@fabszabo Apologies for any negative impact removing the The packages in the Please use the following replacements from the bson package instead:
If you need more help replacing usages of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GODRIVER-2416
Summary
Completely remove the
x/bsonxpackage.Background & Motivation
One of the main goals of the Go Driver 2.0 changes is to reduce code duplication and restructure packages in the Go Driver to minimize import cycles. Some of that restructuring exposes unknown dependencies between packages that must be "untangled" to allow them to operate independently. The
x/bsonxpackage imports somebsonpackages, complicating the restructuring of those packages. Because it is unsupported and effectively unused, we should remove it.Completely remove the
x/bsonxpackage to remove an unsupported API and simplify future restructuring of thebsonpackages. Note that this is a continuation of the work started in GODRIVER-1953 and GODRIVER-1969.