-
Notifications
You must be signed in to change notification settings - Fork 892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GODRIVER-1530 GODRIVER-1213 Fix the enterprise auth test runner. #1118
GODRIVER-1530 GODRIVER-1213 Fix the enterprise auth test runner. #1118
Conversation
ebb2f94
to
1753789
Compare
c2b6a40
to
28e1fbc
Compare
28e1fbc
to
08dbbb9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Evergreen changes and the new testentauth/main.go
LGTM.
Those examples definitely look outdated; I think I'm fine removing, as I don't see what to replace the examples with. But, can we also close GODRIVER-2527 and remove the x/mongo/driver/examples
folder entirely?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Benjamin Rewis <32186188+benjirewis@users.noreply.github.com>
45dbdee
to
42f0694
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM assuming tests pass, thank you.
Co-authored-by: Benjamin Rewis <32186188+benjirewis@users.noreply.github.com>
GODRIVER-1530, GODRIVER-1213
Summary
mongo.Connect
instead oftopology.New
.MONGODB_URI
environment variable and ensure the URI environment variable is always passed to the test runner.cmd/
directory. Remove all outdated examples from thex/mongo/driver/examples
directory.SERVICE_HOST
auth mechanism property to be specified in a connection string.Background & Motivation
#1044 broke the enterprise auth tests, which are only run on the waterfall and went unnoticed until now. That PR broke the tests because it didn't pull the database name from the connection string, instead it used "test" for all tests. In any case, we shouldn't use the unstable
topology.Topology
APIs for the enterprise auth tests anyway because it's not representative of how most people use enterprise auth (most use themongo.Client
type viamongo.Connect
).Refactor the enterprise auth test runner to use
mongo.Connect
instead oftopology.New
, loading the MongoDB test URI from theMONGODB_URI
environment variable and using thedefaultauthdb
database name from the connection string, and move the test runner to thecmd/
directory. Remove all outdated examples from thex/mongo/driver/examples
directory.