Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix filtering with operator not like issue #1829

Merged
merged 3 commits into from
Sep 13, 2019
Merged

fix filtering with operator not like issue #1829

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9d7d0c7
fix filtering with operator not like issue
ahmedsayedabdelsalam Sep 13, 2019
74c4202
replcae string operation with exact match of (not like)
ahmedsayedabdelsalam Sep 13, 2019
30098cd
add test to not like oepration fix
ahmedsayedabdelsalam Sep 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/Jenssegers/Mongodb/Query/Builder.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -978,9 +978,13 @@ protected function compileWhereBasic(array $where)
{
extract($where);

// Replace like with a Regex instance.
if ($operator == 'like') {
$operator = '=';
// Replace like or not like with a Regex instance.
if (in_array($operator, ['like', 'not like'])) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add additional test case for not like here please

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any chance you could add a test as well?

I added the test case and replaced the string operation as suggested.

if (Str::startsWith($operator, 'not')) {
Copy link
Contributor

@jenssegers jenssegers Sep 13, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to do string operations here:

Suggested change
if (Str::startsWith($operator, 'not')) {
if ($operator === 'not like') {

$operator = 'not';
} else {
$operator = '=';
}

// Convert to regular expression.
$regex = preg_replace('#(^|[^\\\])%#', '$1.*', preg_quote($value));
Expand Down