Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update originalIsEquivalent to work with Laravel 5.8 #1712

Merged
merged 1 commit into from
Feb 27, 2019

Conversation

filipac
Copy link
Contributor

@filipac filipac commented Feb 26, 2019

The originalIsEquivalent method of the Illuminate\Database\Eloquent\Concerns\HasAttributes trait has been changed from protected to public.

All that we need to do to make this work with Laravel 5.8 si to change this method to public, all the rest of the functionality seems to work.

@filipac
Copy link
Contributor Author

filipac commented Feb 26, 2019

laravel/framework#26391

@leduonggithub
Copy link

leduonggithub commented Feb 27, 2019

@filipac @jenssegers
When i update Laravel to 5.8, i got the error that require "...protected to public", seems like your problem.
Change it according to your way, does it affect other parts?

@filipac
Copy link
Contributor Author

filipac commented Feb 27, 2019

@leduonggithub It does not seem like it does :) I use my fork now in 5.8 until this will be usable in 5.8 and everything works.

@leduonggithub
Copy link

@filipac
Thank you for your information.
My problem is same this #1713.
Hope Jenssegers consider this issue soon.

@filipac
Copy link
Contributor Author

filipac commented Feb 27, 2019

@leduonggithub when he has time. In the meantime you can use my fork to make it work with 5.8, maybe you find other errors to be fixed.

Add this to your composer.json:

"repositories": [
    {
      "type": "vcs",
      "url": "https://github.com/graphicms/laravel-mongodb"
    }
  ]

@leduonggithub
Copy link

Thank @filipac I will try it.

@jenssegers
Copy link
Contributor

This PR will fail for all other versions lower than 5.8 right?

@filipac
Copy link
Contributor Author

filipac commented Feb 27, 2019

@jenssegers yes, it should be a new version that is backward incompatible.

@jenssegers jenssegers merged commit 5897258 into mongodb:master Feb 27, 2019
mnphpexpert added a commit to mnphpexpert/laravel-mongodb that referenced this pull request Sep 2, 2024
Update originalIsEquivalent to work with Laravel 5.8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants