-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update originalIsEquivalent to work with Laravel 5.8 #1712
Conversation
@filipac @jenssegers |
@leduonggithub It does not seem like it does :) I use my fork now in 5.8 until this will be usable in 5.8 and everything works. |
@leduonggithub when he has time. In the meantime you can use my fork to make it work with 5.8, maybe you find other errors to be fixed. Add this to your composer.json: "repositories": [
{
"type": "vcs",
"url": "https://github.com/graphicms/laravel-mongodb"
}
] |
Thank @filipac I will try it. |
This PR will fail for all other versions lower than 5.8 right? |
@jenssegers yes, it should be a new version that is backward incompatible. |
Update originalIsEquivalent to work with Laravel 5.8
The originalIsEquivalent method of the Illuminate\Database\Eloquent\Concerns\HasAttributes trait has been changed from protected to public.
All that we need to do to make this work with Laravel 5.8 si to change this method to public, all the rest of the functionality seems to work.