Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(NODE-4819): add custom inspect support for other js runtimes #519

Closed
wants to merge 1 commit into from

Conversation

erfanium
Copy link

@erfanium erfanium commented Nov 11, 2022

Description

Due to lack of standard, every js runtime uses their own custom inspect. in this PR i've added support for Deno custom inspect symbol. (new runtimes can be added as well in future)

As #518 have been merged, this library aims to work on other js platforms as well

Is there new documentation needed for these changes?

No

What is the motivation for this change?

Double check the following

  • Ran npm run lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: <type>(NODE-xxxx)<!>: <description>
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@erfanium
Copy link
Author

PR title follows the correct format: <type>(NODE-xxxx)<!>: <description>

should I create a new Jira issue for it?

@dariakp dariakp changed the title feat: add custom inspect support for other js runtimes feat(NODE-4819): add custom inspect support for other js runtimes Nov 11, 2022
@dariakp
Copy link
Contributor

dariakp commented Nov 11, 2022

@erfanium one was automatically created for it, but please do feel free to add more context either here or in the jira ticket (NODE-4819) so that the team can better understand your use case when we review it next week

@baileympearson
Copy link
Contributor

Hey @erfanium - thanks again for submitting this PR.

At this time, we don't have the testing infrastructure to test features specific to Deno and are unable to accept this change at this time.

I added the generated Jira ticket to our Deno support epic on Jira and we will make sure we revisit this in the future when we consider official support for Deno.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants