Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make inspect for ObjectId work #412

Merged
merged 1 commit into from
Nov 13, 2020
Merged

Commits on Nov 5, 2020

  1. fix: make inspect for ObjectId work

    The previous `Object.defineProperty()` calls did not work because
    they did not specify a property descriptor, and even if they had
    worked, the signatures of `.inspect()` and `.toString()` would
    have mismatched, and even if they weren’t, the result would not
    have been very useful as debugging output, because it only returned
    the raw hex content of the `ObjectId` and not even e.g. the fact
    that this object is an `ObjectId`.
    
    I’m happy with any other solution, but this particular one would
    make my life a tiny bit easier :)
    addaleax committed Nov 5, 2020
    Configuration menu
    Copy the full SHA
    13d75b7 View commit details
    Browse the repository at this point in the history