Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOCSP-41828 - Remove legacy package #230

Merged
merged 5 commits into from
Sep 17, 2024
Merged

DOCSP-41828 - Remove legacy package #230

merged 5 commits into from
Sep 17, 2024

Conversation

mongoKart
Copy link
Collaborator

@mongoKart mongoKart commented Sep 17, 2024 •
edited by github-actions bot
Loading

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-41828

Staging Links

  • whats-new

    • Self-Review Checklist

    • Is this free of any warnings or errors in the RST?
    • Did you run a spell-check?
    • Did you run a grammar-check?
    • Are all the links working?
    • Are the facets and meta keywords accurate?

    @netlify Netlify
    Copy link

    netlify bot commented Sep 17, 2024 •
    edited
    Loading

    ✅ Deploy Preview for mongodb-docs-csharp ready!

    Name Link
    🔨 Latest commit bc838b2
    🔍 Latest deploy log https://app.netlify.com/sites/mongodb-docs-csharp/deploys/66e9e2979b38c800080ac8d5
    😎 Deploy Preview https://deploy-preview-230--mongodb-docs-csharp.netlify.app
    📱 Preview on mobile
    Toggle QR Code...

    QR Code

    Use your smartphone camera to open QR code link.

    To edit notification comments on pull requests, go to your Netlify site configuration.

    mongoKart
    mongoKart commented Sep 17, 2024
    View reviewed changes
    .github/workflows/copy-compat-to-docs-shared.yml
    Copy link
    Collaborator Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    unrelated to docs ticket

    @mongoKart mongoKart requested review from a team and adelinowona and removed request for a team September 17, 2024 20:35
    BorisDog
    BorisDog approved these changes Sep 17, 2024
    View reviewed changes
    Copy link
    Collaborator

    @BorisDog BorisDog left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    LGTM

    @mongoKart mongoKart merged commit d50f7bf into mongodb:v3.0 Sep 17, 2024
    6 of 7 checks passed
    @mongoKart mongoKart deleted the docsp-41828-remove-legacy branch September 17, 2024 22:16
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @rustagir rustagir rustagir approved these changes

    @BorisDog BorisDog BorisDog approved these changes

    @adelinowona adelinowona Awaiting requested review from adelinowona adelinowona was automatically assigned from mongodb/dbx-csharp-dotnet

    Assignees
    No one assigned
    Labels
    None yet
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    3 participants
    @mongoKart @BorisDog @rustagir