Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for block-commented json attributes #95

Merged
merged 5 commits into from
May 20, 2022
Merged

Add test for block-commented json attributes #95

merged 5 commits into from
May 20, 2022

Conversation

cbush
Copy link
Collaborator

@cbush cbush commented May 11, 2022

No description provided.

nathan-contino-mongo
nathan-contino-mongo approved these changes May 18, 2022
View reviewed changes
Copy link
Contributor

@nathan-contino-mongo nathan-contino-mongo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good thinking about this use case, kind of silly that I've always used single-line comments until now...

@cbush cbush merged commit 734b7be into mongodb-university:main May 20, 2022
@cbush cbush deleted the block-comment-attr branch May 20, 2022 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathan-contino-mongo nathan-contino-mongo nathan-contino-mongo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cbush @nathan-contino-mongo