fix(cursor): do not truncate an existing Long

[jasontho-ms]

This is a fix for issue #440

[daprahamian]

@jasontho-ms are you sure this is necessary? I just ran the following in the terminal and it seems okay.

const bson = require('bson');
const assert = require('assert');

assert.ok(bson.Long.fromNumber(bson.Long.MAX_VALUE).equals(bson.Long.MAX_VALUE))

[jasontho-ms]

MAX_VALUE has no low bits so it works, but try it with one less than MAX_VALUE so it has low bits:

bson.Long.MAX_VALUE.toString()
'9223372036854775807'
const foo = bson.Long.fromString('9223372036854775806')
foo
Long { bsontype: 'Long', low: -2, high_: 2147483647 }
assert.ok(bson.Long.fromNumber(foo).equals(foo))
AssertionError [ERR_ASSERTION]: false == true

[daprahamian]

@jasontho-ms Ah, good point.

[daprahamian]

Thank you for this @jasontho-ms. As a heads up, we have merged mongodb-core and node-mongodb-native together for our next minor release. I can take care of porting this over to the new version, but you will lose credit for the commit. Do you want to take care of making this PR against the next branch of node-mongodb-native, or would you like me to take care of it. Let me know which works best.

- Dan

[jasontho-ms]

Internet points don’t matter 😊 I’d appreciate it if you port it over. Thanks for taking a look! From: Dan Aprahamian <notifications@github.com> Sent: Wednesday, June 12, 2019 2:22 PM To: mongodb-js/mongodb-core <mongodb-core@noreply.github.com> Cc: Jason Thorsness <jasontho@exchange.microsoft.com>; Mention <mention@noreply.github.com> Subject: Re: [mongodb-js/mongodb-core] fix(cursor): do not truncate an existing Long (#441) @daprahamian approved this pull request. Thank you for this @jasontho-ms<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fjasontho-ms&data=02%7C01%7Cjasontho%40exchange.microsoft.com%7C9ac77dec58e2488ae35108d6ef7c08a6%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636959713346774427&sdata=r0Iulwg0t8rQiX44%2FqR9Oa1YMhrflic9KozwLD6iH5s%3D&reserved=0>. As a heads up, we have merged mongodb-core and node-mongodb-native together for our next minor release. I can take care of porting this over to the new version, but you will lose credit for the commit. Do you want to take care of making this PR against the next branch of node-mongodb-native, or would you like me to take care of it. Let me know which works best. - Dan — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmongodb-js%2Fmongodb-core%2Fpull%2F441%3Femail_source%3Dnotifications%26email_token%3DAESIW5HGU36CPKCKOMSVTMTP2FSIHA5CNFSM4HXDUNE2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB3L5J5Q%23pullrequestreview-249025782&data=02%7C01%7Cjasontho%40exchange.microsoft.com%7C9ac77dec58e2488ae35108d6ef7c08a6%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636959713346784419&sdata=k2kT4GYB2ED9nFK2gjfPduLoARuLSYmTle8CpQobGaQ%3D&reserved=0>, or mute the thread<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAESIW5BDKBX743ATHK6PANDP2FSIHANCNFSM4HXDUNEQ&data=02%7C01%7Cjasontho%40exchange.microsoft.com%7C9ac77dec58e2488ae35108d6ef7c08a6%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636959713346784419&sdata=0uoU7rImVxzsCBWTtrLCmI7RT8Axad1pigAhHmhO2EM%3D&reserved=0>.

[daprahamian]

Merged. Thank you for the contribution @jasontho-ms!