feat(NODE-6161): Sign Releases #177
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbbeeken
changed the title
nbbeeken
reviewed
Jun 20, 2024
nbbeeken
reviewed
Jun 20, 2024
nbbeeken
reviewed
Jun 20, 2024
|
https://github.com/mongodb-js/kerberos/actions/runs/9619287117 |
aditi-khare-mongoDB
had a problem deploying
to
release
GitHub Actions
Failure
aditi-khare-mongoDB
had a problem deploying
to
release
GitHub Actions
Failure
aditi-khare-mongoDB
had a problem deploying
to
release
GitHub Actions
Failure
aditi-khare-mongoDB
had a problem deploying
to
release
GitHub Actions
Failure
durran
requested changes
Jun 27, 2024
| ``` | ||
|
|
||
| >[!Note] | ||
| No verification is done when using npm to install the package. To ensure release integrity when using npm, download the tarball manually from the GitHub release, verify the signature, then install the package from the downloaded tarball using npm install mongodb-X.Y.Z.tgz. |
There was a problem hiding this comment.
Suggested change
| No verification is done when using npm to install the package. To ensure release integrity when using npm, download the tarball manually from the GitHub release, verify the signature, then install the package from the downloaded tarball using npm install mongodb-X.Y.Z.tgz. | |
| No verification is done when using npm to install the package. To ensure release integrity when using npm, download the tarball manually from the GitHub release, verify the signature, then install the package from the downloaded tarball using npm install kerberos-X.Y.Z.tgz. |
|
duplicates #179 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sign releases, tar ball and .node native files.
What is changing?
Add signatures to releases.
Is there new documentation needed for these changes?
Yes, README.md has been updated.
What is the motivation for this change?
SSDLC compliance.
Release Highlight
Fill in title or leave empty for no highlight
Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript