Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better mousedown handling on existing selection #111

Merged
merged 1 commit into from
Aug 25, 2015
Merged

better mousedown handling on existing selection #111

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/minicharts/d3fns/date.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,13 +113,16 @@ var minicharts_d3fns_date = function() {
};
options.view.trigger('querybuilder', evt);
};

function handleMouseDown() {
var line = this;
var parent = $(this).closest('.minichart');
var background = parent.find('g.brush > rect.background')[0];
var brushNode = parent.find('g.brush')[0];
var start = barcodeX.invert(d3.mouse(background)[0]);
brushstart.call(brushNode, line);
var brushstartOnce = _.once(function() {
brushstart.call(brushNode, line);
});

var w = d3.select(window)
.on('mousemove', mousemove)
Expand All @@ -128,6 +131,7 @@ var minicharts_d3fns_date = function() {
d3.event.preventDefault(); // disable text dragging

function mousemove() {
brushstartOnce();
var extent = [start, barcodeX.invert(d3.mouse(background)[0])];
d3.select(brushNode).call(brush.extent(_.sortBy(extent)));
brushed.call(brushNode);
Expand Down
5 changes: 4 additions & 1 deletion src/minicharts/d3fns/few.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,9 @@ var minicharts_d3fns_few = function() {
var background = parent.find('g.brush > rect.background')[0];
var brushNode = parent.find('g.brush')[0];
var start = xScale.invert(d3.mouse(background)[0]);
brushstart.call(brushNode, rect);
var brushstartOnce = _.once(function() {
brushstart.call(brushNode, rect);
});

var w = d3.select(window)
.on('mousemove', mousemove)
Expand All @@ -115,6 +117,7 @@ var minicharts_d3fns_few = function() {
d3.event.preventDefault(); // disable text dragging

function mousemove() {
brushstartOnce();
var extent = [start, xScale.invert(d3.mouse(background)[0])];
d3.select(brushNode).call(brush.extent(_.sortBy(extent)));
brushed.call(brushNode);
Expand Down
5 changes: 4 additions & 1 deletion src/minicharts/d3fns/many.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,9 @@ var minicharts_d3fns_many = function() {
var background = parent.find('g.brush > rect.background')[0];
var brushNode = parent.find('g.brush')[0];
var start = d3.mouse(background)[0];
brushstart.call(brushNode, bar);
var brushstartOnce = _.once(function() {
brushstart.call(brushNode, bar);
});

var w = d3.select(window)
.on('mousemove', mousemove)
Expand All @@ -119,6 +121,7 @@ var minicharts_d3fns_many = function() {
d3.event.preventDefault(); // disable text dragging

function mousemove() {
brushstartOnce();
var extent = [start, d3.mouse(background)[0]];
d3.select(brushNode).call(brush.extent(_.sortBy(extent)));
brushed.call(brushNode);
Expand Down