Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to electron 0.30.5 #109

Merged
merged 2 commits into from
Aug 25, 2015
Merged

Upgrade to electron 0.30.5 #109

merged 2 commits into from
Aug 25, 2015

Conversation

kangas
Copy link
Contributor

@kangas kangas commented Aug 23, 2015

Bump electron version to latest 0.30 version which is 0.30.5. This resolves some ASAR problems I encountered on Windows.

I don't want to use 0.31.0 yet: it upgrades io.js and thus breaks native modules.

@kangas
Copy link
Contributor Author

kangas commented Aug 24, 2015

Testing on OS X: "npm run release" builds an app, connection panel works normally, but the primary window (after connection selected) is blank. :(

I see the following (possibly unrelated):

Mon, 24 Aug 2015 22:15:46 GMT scout-electron:window-manager creating new window
Mon, 24 Aug 2015 22:15:46 GMT scout-electron:menu attaching window menu
[51752:0824/181546:INFO:CONSOLE(124)] "It is not allowed to open new window from this WebContents", source: /Users/kangas/workspace/scout/dist/MongoDB Scout-darwin-x64/MongoDB Scout.app/Contents/Resources/atom.asar/renderer/lib/override.js (124)

imlucas added a commit that referenced this pull request Aug 25, 2015
@imlucas imlucas merged commit 822638d into master Aug 25, 2015
@imlucas imlucas deleted the electron-0.30 branch August 25, 2015 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants