Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: refine while loop limit handling #2069

Merged

Conversation

wolfsolver
Copy link
Member

@wolfsolver wolfsolver commented Jan 11, 2025

Add code with some refinement (but not hope that this solve issue) and improve log, so we can ask to some one that get error to share logcat

@wolfsolver wolfsolver linked an issue Jan 11, 2025 that may be closed by this pull request
@guanlisheng
Copy link
Contributor

there is no such issue since v2025.01.01 and i suspect it (#2042) has beed fixed along with #2041

@wolfsolver
Copy link
Member Author

Ok. anyway this is a better readable code (moving limit into while statement).
Can you confirm?

@guanlisheng guanlisheng changed the title Try to fix #2042 Refactor: refine while loop limit handling Jan 12, 2025
@guanlisheng guanlisheng merged commit 3ac9cc9 into master Jan 12, 2025
4 checks passed
@wolfsolver wolfsolver deleted the 2042-anr-commoneymanagerexdatalayerrepositorybasefirst branch January 12, 2025 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ANR: com.money.manager.ex.datalayer.RepositoryBase.first
2 participants