add root to factory function when loading with modules

[jfspencer]

@ulfryk @cwmyers this change gets Monet.js working in my ES6 project, tests are passing. Is root expected to be window in browser contexts? let me know if I need to go in a different direction and I will update the PR.

[ulfryk]

@jfspencer - thanks for contribution :)

Your direction seems to be 100% OK.

Just please fix issues that break tests. And make us 100% sure that test on window will not 💥 on window detection. I have a feeling that there is some possibility that try / catch clause may be needed instead of ternary operator.

[przemyslawjanpietrzak]

window || root will be shorter.

[jfspencer]

@ulfryk updated to use try/catch, with passing the existing tests. not sure how to unit test this though 🤔

[ulfryk]

@jfspencer - to be sure if we're doing it right I searched for info about UMD patterns and found that it all can be actually done much simpler :)
See: https://github.com/umdjs/umd
Especially: https://github.com/umdjs/umd/blob/master/templates/returnExports.js

so:

    …
    } else if (typeof module === 'object' && module.exports) {
        module.exports = factory(root) //yeah, just root instead of window
    } else {
    …
  // and this tricky ternary here instead of just this
}(typeof self !== 'undefined' ? self : this, function (rootGlobalObject) {

and please update also src/monet-pimp.js

Sorry for confusion - this part with UMD is in my opinion not a thing that coders should do (and I'm never up to date with it) - language should care about it :)

We should move away from writing it by ourselves here and probably switch to Rollup or webpack ( #181 )

[jfspencer]

@ulfryk Good to know, thanks for clarifying that. updated the PR accordingly.