Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lmdb txn commit code #9290

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vtnerd
Copy link
Contributor

@vtnerd vtnerd commented Apr 14, 2024

I added LMDB code to monero core a while ago. The only project (afaik) using it is LWS. I found this bug in the commit code - commit can fail with a resize request too.

If anyone thinks this code should be removed and put into LWS let me know shortly. I thought perhaps this could be used to replace existing LMDB code, but it looks unlikely at this point.

@0xFFFC0000
Copy link
Collaborator

LGTM semantically and syntactically.

I will approve this in few days if anyone not raise any issues about having this here.

@vtnerd
Copy link
Contributor Author

vtnerd commented Jun 4, 2024

Embarrassing, this still has a bug in it. I will post an updated version, with an additional fix for the commit function.

@vtnerd
Copy link
Contributor Author

vtnerd commented Jun 4, 2024

@0xFFFC0000 sorry for the changes, but I added a few more. If they get accepted, I will do a release branch version too. LWS is a little "shaky" without the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants