Update bubbletea package. Reenable TTY detection #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
preslavgerchev
commented
Nov 15, 2022
| @@ -62,7 +62,7 @@ func NewMultiBar(id string, data progressData) *progressbar { | |||
| id: id, | |||
| maxNameWidth: maxNameWidth, | |||
| Data: data, | |||
| isTTY: isatty.IsTerminal(os.Stdout.Fd()) && false, // FIXME: re-enable the detection | |||
| isTTY: isatty.IsTerminal(os.Stdout.Fd()), | |||
There was a problem hiding this comment.
Do we still support piping args into cnspec? If not, maybe we can remove some code here (lines 84-96):
// else if not a TTY (but piped?)
else {
go func() {
for {
time.Sleep(time.Second / progressPipedFps)
if p.Data.complete {
break
}
fmt.Print(p.View() + "\r\033[2A")
}
fmt.Print(p.View())
}()
}
There was a problem hiding this comment.
Good point, lets revisit that if we can simplify the approach here
chris-rock
force-pushed
the
preslav/consistent-progress-bar
branch
from
454d2ce to
54e13c7
Compare
|
rebased on #192 |
chris-rock
approved these changes
Nov 15, 2022
| @@ -62,7 +62,7 @@ func NewMultiBar(id string, data progressData) *progressbar { | |||
| id: id, | |||
| maxNameWidth: maxNameWidth, | |||
| Data: data, | |||
| isTTY: isatty.IsTerminal(os.Stdout.Fd()) && false, // FIXME: re-enable the detection | |||
| isTTY: isatty.IsTerminal(os.Stdout.Fd()), | |||
There was a problem hiding this comment.
Good point, lets revisit that if we can simplify the approach here
Signed-off-by: Preslav <preslav@mondoo.com>
chris-rock
force-pushed
the
preslav/consistent-progress-bar
branch
from
54e13c7 to
885bd5b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #167