Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⭐ Use cnspec container image #40

Merged
merged 44 commits into from
Nov 16, 2022
Merged

Conversation

czunker
Copy link
Contributor

@czunker czunker commented Oct 27, 2022

Signed-off-by: Christian Zunker christian@mondoo.com

Signed-off-by: Christian Zunker <christian@mondoo.com>
@github-actions

This comment has been minimized.

@czunker
Copy link
Contributor Author

czunker commented Oct 27, 2022

Depends on mondoohq/cnspec#153

When the image is present and the action for docker images works, I'll extend it to the other actions.

Signed-off-by: Christian Zunker <christian@mondoo.com>
Signed-off-by: Christian Zunker <christian@mondoo.com>
@czunker
Copy link
Contributor Author

czunker commented Oct 27, 2022

@benr Could you please have a look at the failing CLA check? From what I understood it seems there is a secret missing for this repo.

Signed-off-by: Christian Zunker <christian@mondoo.com>
Signed-off-by: Christian Zunker <christian@mondoo.com>
Signed-off-by: Christian Zunker <christian@mondoo.com>
@czunker
Copy link
Contributor Author

czunker commented Nov 2, 2022

The additional args currently do not work:
https://github.com/mondoohq/actions/actions/runs/3375902868/jobs/5603014936

Signed-off-by: Christian Zunker <christian@mondoo.com>
Signed-off-by: Christian Zunker <christian@mondoo.com>
@czunker
Copy link
Contributor Author

czunker commented Nov 2, 2022

Strangely the image scan action fails, but I cannot reproduce it locally.

Signed-off-by: Christian Zunker <christian@mondoo.com>
Signed-off-by: Christian Zunker <christian@mondoo.com>
@czunker
Copy link
Contributor Author

czunker commented Nov 2, 2022

Opened an issue for the problem: mondoohq/cnspec#157

I managed to reproduce it locally by setting all the GITHUB_ env vars and running cnspec.

Signed-off-by: Christian Zunker <christian@mondoo.com>
Signed-off-by: Christian Zunker <christian@mondoo.com>
Fixes mondoohq/cnspec#171

Signed-off-by: Christian Zunker <christian@mondoo.com>
@czunker czunker force-pushed the christian/switch_to_container_image branch from 200153f to 1f89cd8 Compare November 9, 2022 04:59
Signed-off-by: Christian Zunker <christian@mondoo.com>
Signed-off-by: Christian Zunker <christian@mondoo.com>
Signed-off-by: Christian Zunker <christian@mondoo.com>
@czunker czunker marked this pull request as ready for review November 9, 2022 09:54
@czunker czunker changed the title WIP: ⭐ Use container image ⭐ Use cnspec container image Nov 9, 2022
@czunker czunker requested a review from scottford-io November 9, 2022 09:54
@czunker
Copy link
Contributor Author

czunker commented Nov 9, 2022

This is a demo run of the new action in the operator repo: https://github.com/mondoohq/mondoo-operator/actions/runs/3427117500/jobs/5709741631

Just for comparison a previous run, with all the apt update steps in it: https://github.com/mondoohq/mondoo-operator/actions/runs/3414905633/jobs/5683488242

@czunker czunker force-pushed the christian/switch_to_container_image branch from 843abde to 71434dc Compare November 11, 2022 06:38
Signed-off-by: Christian Zunker <christian@mondoo.com>
Signed-off-by: Christian Zunker <christian@mondoo.com>
@czunker czunker force-pushed the christian/switch_to_container_image branch 3 times, most recently from d4eea2e to eef2de5 Compare November 11, 2022 08:52
Signed-off-by: Christian Zunker <christian@mondoo.com>
@czunker czunker force-pushed the christian/switch_to_container_image branch from eef2de5 to 658f2e8 Compare November 11, 2022 08:52
Signed-off-by: Christian Zunker <christian@mondoo.com>
Signed-off-by: Christian Zunker <christian@mondoo.com>
Signed-off-by: Christian Zunker <christian@mondoo.com>
@czunker
Copy link
Contributor Author

czunker commented Nov 11, 2022

I had to revert the changes for the policy action, because cnspec does not know about policy.

@czunker czunker requested a review from tas50 November 11, 2022 09:22
Signed-off-by: Christian Zunker <christian@mondoo.com>
Signed-off-by: Christian Zunker <christian@mondoo.com>
Signed-off-by: Christian Zunker <christian@mondoo.com>
Signed-off-by: Christian Zunker <christian@mondoo.com>
Signed-off-by: Christian Zunker <christian@mondoo.com>
Signed-off-by: Christian Zunker <christian@mondoo.com>
Copy link
Contributor

@scottford-io scottford-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@czunker Great work! I just noticed one more issue with the github-org and github-repo action and requested that we move from the --token arg to using the env config with GITHUB_TOKEN

Other than that, I am good to go!

Signed-off-by: Christian Zunker <christian@mondoo.com>
@czunker czunker merged commit 3b6da9c into main Nov 16, 2022
@czunker czunker deleted the christian/switch_to_container_image branch November 16, 2022 16:56
@github-actions github-actions bot locked and limited conversation to collaborators Nov 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants