-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Splitted docs #6
base: master
Are you sure you want to change the base?
Conversation
Can you upload a release package? so releases is non-emmpty? |
@samirjorina, @digitalfishpond please have a look |
|
||
### Log agent | ||
Please use the embedded help for detailed and up-to-date info: | ||
``` | ||
./log-agent-<logstash_version>_<logstash_output_monsaca_log_api_version>.run --help | ||
./log-agent-<version>.run --help |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to confirm, here: do you want to remove the user's ability to specify a logstash version at the time of creating the log-agent installer? Or do you just want to reduce the name of the .run file to not include the logstash version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have to distinguish between user and developer. It is ok that a developer (you) to specify the logstash version. However, does it makes sense for users that search for a package on the releases page to include library version numbers into monasca artifact names? What happens if you fix the shell scritps and create a new download package? Do you keep the same version number? Sounds very strange to me.
To answer you question: in my understanding the version should be aligned with monasca version. How should a user know what to download in case the artifacts are not named cohesively ?
E.g. lets say you have installed Monasca version 'pike', than a user probably wants to download a package named pike as well
Moved development part into separate document
Assumed that binaries will be named according to openstack release
Adjusted docs accordingly