# CX-17328 - fix(release): update event flow for date picker #1861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Events need to propogate to the UI impl on blank values for dates.
NotNestor
previously approved these changes
Jan 16, 2025
cormacmchale1
changed the title
Events need to propogate to the UI impl on blank values for dates.
cormacmchale1
commented
Jan 16, 2025
| if (this.value && changedProperties.has("value")) { | ||
| this.parseValueForVisuals(this.value); | ||
| if (changedProperties.has("value")) { | ||
| if (this.value) { |
There was a problem hiding this comment.
Again here. To tell the UI about the blank value we need to not bail out here
cormacmchale1
commented
Jan 16, 2025
| } | ||
| else | ||
| { |
There was a problem hiding this comment.
This is worth talking about. This will send a datetime back as
Which is correct but worth flagging
There was a problem hiding this comment.
Needs to be done in this manner as typescript won't allow the use of this.value without the check.
There was a problem hiding this comment.
The formatting on the code is updated since this commit
Events need to propogate to the UI impl on blank values for dates.
NotNestor
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Events need to propogate to the UI impl on blank values for dates. So that the UI can respond appropriately.
Description
The if statement would ignore blank values, and the method flow would propogate the previous value, which is then ignored by DateTimePicker.ts in it's updated flow.
Related Issue
Motivation and Context
Makes sure any UI that implements this can respond if required to a blank value entering the input field for the date picker.
How Has This Been Tested?
Manually(Sandbox) and in tests.
Screenshots:
Before (If applicable):
After:
Types of changes
Checklist: